Avoid installing to '/sdf/sw/epics/base/7.0.3.1-1.0' in non-release builds of base#1
Open
JJL772 wants to merge 1 commit intoR7.1.1-1.branchfrom
Open
Avoid installing to '/sdf/sw/epics/base/7.0.3.1-1.0' in non-release builds of base#1JJL772 wants to merge 1 commit intoR7.1.1-1.branchfrom
JJL772 wants to merge 1 commit intoR7.1.1-1.branchfrom
Conversation
…uilds of base In epics-base itself, modules/CONFIG_SITE.local defines INSTALL_LOCATION to be $(EPICS_BASE) as a way to bundle the modules together, while allowing them to be installed separately from EPICS base (if the user so chooses to clone+build them separately). This works fine because $(EPICS_BASE) is set to $(TOP) at some point before descending into the modules. However, if we set our own $(EPICS_BASE), then we override the EPICS_BASE=$(TOP) and accidentally install to the release location of base. Oops!
Member
|
Best I can recall the RELEASE.local file was added to support building pvAccessCPP and the other PVA related modules as standalone EPICS modules. This was needed prior to EPICS 7, but now they are built in place as submodules in EPICS base. I don't think we even need this RELEASE.local if you're building pvAccessCPP in place under EPICS base. |
Member
Author
|
I figured it would be worthwhile to keep in case it needs to be built separately for testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a HUGE landmine where clones of SLAC's EPICS base would install pvAccess to the release location (under ${EPICS_SITE_TOP}/base/${BASE_MODULE_VERSION})
In epics-base itself, modules/CONFIG_SITE.local defines INSTALL_LOCATION to be $(EPICS_BASE) as a way to bundle the modules together, while allowing them to be installed separately from EPICS base (if the user so chooses to clone+build them separately).
This works fine because$(EPICS_BASE) is set to $ (TOP) at some point before descending into the modules.$(EPICS_BASE), then we override the EPICS_BASE=$ (TOP) and accidentally install to the release location of base. Oops!
However, if we set our own