Skip to content

Included expected and actual in error message when arrays are not the same size #108 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericssy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Included expected and actual in error message when arrays are not the same size #108 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/skyscreamer/jsonassert/comparator/DefaultComparator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ public void compareValues(String prefix, Object expectedValue, Object actualValu
public void compareJSONArray(String prefix, JSONArray expected, JSONArray actual, JSONCompareResult result)
throws JSONException {
if (expected.length() != actual.length()) {
result.fail(prefix + "[]: Expected " + expected.length() + " values but got " + actual.length());
result.fail(prefix + "[]: Expected " + expected.length() + " values but got " + actual.length() + ", "
+ "Expected: " + expected + ", " + "Actual: " + actual);
return;
} else if (expected.length() == 0) {
return; // Nothing to compare
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/skyscreamer/jsonassert/JSONCompareTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void succeedsWithEmptyArrays() throws JSONException {
@Test
public void reportsArraysOfUnequalLength() throws JSONException {
JSONCompareResult result = compareJSON("[4]", "[]", LENIENT);
assertThat(result, failsWithMessage(equalTo("[]: Expected 1 values but got 0")));
assertThat(result, failsWithMessage(equalTo("[]: Expected 1 values but got 0, Expected: [4], Actual: []")));
}

@Test
Expand Down