Remove react hook and use javascript to detect theme state#15
Remove react hook and use javascript to detect theme state#15msoham123 wants to merge 7 commits intoskyline-emu:masterfrom
Conversation
|
|
||
| const IndexPage = () => { | ||
|
|
||
| configureDarkMode(); |
There was a problem hiding this comment.
I'm just thinking not tried but is it working when we go to another page? It looks like it is working on index page but what happens if we go to download page? Is it still works because it looks like you are just adding dark class on index page
There was a problem hiding this comment.
Good catch, I didn't even think about that. It seems to maintain state when navigating to the download page, which makes sense, but then upon reload defaults to light. I added the method to all pages and now it works fine, no flash and respects system theme, for all of them (even upon changing in system settings and navigating to the page.)
| import "react"; | ||
|
|
||
| const colorSchemeMedia = "(prefers-color-scheme: dark)"; | ||
| const isBrowser = () => typeof window !== "undefined" |
There was a problem hiding this comment.
Extract this into some utility file and also use it in CustomLink/Button.
| const isBrowser = () => typeof window !== "undefined" | ||
|
|
||
| const configureDarkMode = () => { | ||
|
|
|
|
||
| // TODO: Add a switch that respects local storage and allows user to choose |
There was a problem hiding this comment.
If something is fully functional in itself then there's no need to add TODOs.
|
|
||
|
|
||
| const IndexPage = () => { | ||
|
|
| const isDark = useDarkModeState(); | ||
|
|
||
| const Layout = ({ children, title}) => { | ||
|
|
3 participants
This fixes the initial flash that can be seen when opening the page and using a system default of dark mode.
In the future, I'd like to add local storage based dark mode handling, so this opens that up as well.