Fix team card layout and assign keys to cards#14
Open
msoham123 wants to merge 2 commits intoskyline-emu:masterfrom
Open
Fix team card layout and assign keys to cards#14msoham123 wants to merge 2 commits intoskyline-emu:masterfrom
msoham123 wants to merge 2 commits intoskyline-emu:masterfrom
Conversation
PixelyIon
reviewed
Jan 3, 2023
| </div> | ||
| <div className="flex flex-col flex-none items-start"> | ||
| <div className="-mt-8 text-2xl font-inter text-stone-600 dark:text-zinc-300 text-left">{name}</div> | ||
| <div className="-mt-8 text-2xl font-inter text-stone-600 dark:text-zinc-300 text-left overflow-hidden lg:text-xl">{name}</div> |
Member
There was a problem hiding this comment.
I was looking into trying to use ellipses when it overflowed but couldn't make it work, maybe you can?
Member
Author
There was a problem hiding this comment.
I tried, but using tailwind's native truncate property didn't seem to work fully. https://stackoverflow.com/questions/53497656/tailwind-text-overflow-ellipsis
It truncates fine, but I can't seem to get ellipses at all for some reason. If you'd like, I can commit this here without the ellipses?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the name overflowing on the longer named team card. Also fixes a react warning being thrown due to the absence of an unique key for each team member in the list.