Skip to content

Conversation

@eugenpodaru
Copy link
Contributor

No description provided.

@eugenpodaru eugenpodaru requested a review from a team as a code owner January 22, 2025 15:38
@pevisscher
Copy link
Contributor

Cool! Do you want me to make a beta release of this before making a major release?

@pevisscher pevisscher closed this Jan 22, 2025
@pevisscher pevisscher reopened this Jan 22, 2025
@eugenpodaru
Copy link
Contributor Author

@pevisscher yes, a beta release sounds good

@pevisscher
Copy link
Contributor

Released as 6.1.0-beta-06c64e9b.1

@pevisscher
Copy link
Contributor

@eugenpodaru are you comfortable promoting this to a new major?

@eugenpodaru
Copy link
Contributor Author

@pevisscher not yet, still testing, and i see that streaming is not working

@eugenpodaru
Copy link
Contributor Author

@pevisscher I pushed some fixes. Can you please release another beta?

@pevisscher
Copy link
Contributor

Released 6.1.0-beta-5844bf48.1

@eugenpodaru
Copy link
Contributor Author

@pevisscher i tweaked the schema a bit more. I had to specifically add additionalProperties: true, since it seems { strict : false } does not do that anymore. Do you know why?

@pevisscher
Copy link
Contributor

So you're seeing a difference between ajv and zod there. For ajv we have to be default allow additionalProperties, because for union types it will otherwise strip out the complement of keys in a non deterministic way. Zod properly handles these types so the defaults from zod are used. By default zod strips any keys that are unknown.

It looks like the current strictness setting on the restclient configuration doesnt do anything anymore. I will think about how to move forward with these kind of configurations.

@eugenpodaru
Copy link
Contributor Author

@pevisscher yeah, makes sense, i can live with that. would you push a new beta?

@pevisscher
Copy link
Contributor

Released 6.1.0-beta-0e48331a.1

@eugenpodaru
Copy link
Contributor Author

@pevisscher I regenerated the clients with the latest therefore. could you please publish a new beta?

@pevisscher
Copy link
Contributor

Released 6.1.0-beta-b9ab2814.1

@eugenpodaru
Copy link
Contributor Author

@pevisscher I pushed a new commit allowing custom fields for a few entities as described here https://support.mambu.com/docs/custom-fields. Let me know what you think about the approach, and if you don't have comments, could you please release another beta? Thank you!

@pevisscher
Copy link
Contributor

Looks fine to me to explicitly allow passthrough on these entity types, it's a trusted source anyway Released under 6.1.0-beta-b9ab2814.1

@eugenpodaru
Copy link
Contributor Author

@pevisscher On npm it says that this version was published 22 days ago. Can you check if a new beta version was published?

@eugenpodaru
Copy link
Contributor Author

@pevisscher i have pushed a commit setting the timeout to false to align with how got behaved. Can you please release another beta?

@pevisscher
Copy link
Contributor

Released v6.1.0-beta-74699a30.1

@eugenpodaru
Copy link
Contributor Author

@pevisscher can you please merge the PR and release it?

@pevisscher pevisscher merged commit 3c013dc into skyleague:main May 13, 2025
7 of 8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eugenpodaru eugenpodaru deleted the 22-01-use-zod-validator branch May 21, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants