Skip to content

SK-2139 return file object in deidentify file response #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raushan-skyflow merged 5 commits into from
Jun 26, 2025
Merged

SK-2139 return file object in deidentify file response #185

raushan-skyflow merged 5 commits into from
Jun 26, 2025

Conversation

@raushan-skyflow
Copy link
Contributor

@raushan-skyflow raushan-skyflow commented Jun 26, 2025 •
edited
Loading

Why:

  • Adding file object in the response so that users can have access to file in the response.
  • And adding file path in the deidentify file request to make it consistent with the response.

Goal

  • The deidentify request should contain file path along with file object in Python SDK V2.
  • And response should contain file object.

Testing

  • Tested the changes in local environment.
  • Added unit tests

@raushan-skyflow raushan-skyflow merged commit 6d8139f into release/25.6.2 Jun 26, 2025
4 checks passed
raushan-skyflow added a commit that referenced this pull request Jul 4, 2025
@raushan-skyflow
Release/25.6.2 (#187)
3a6210b 
* SK-2139 return file object in deidentify file response , None on empty error response (#185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saileshwar-skyflow saileshwar-skyflow saileshwar-skyflow approved these changes

@skyflow-vivek skyflow-vivek Awaiting requested review from skyflow-vivek

+1 more reviewer

@skyflow-shravan skyflow-shravan skyflow-shravan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raushan-skyflow @skyflow-shravan @saileshwar-skyflow