Skip to content

SK-1731: Fix api key inconsistency #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saileshwar-skyflow merged 1 commit into from
Jan 8, 2025
Merged

SK-1731: Fix api key inconsistency #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions skyflow/utils/validations/_validations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import json
import re
from skyflow.service_account import is_expired
from skyflow.utils.enums import LogLevel, Env, RedactionType, TokenMode
from skyflow.error import SkyflowError
Expand Down Expand Up @@ -45,12 +44,15 @@ def validate_required_field(logger, config, field_name, expected_type, empty_err
raise SkyflowError(empty_error, invalid_input_error_code)

def validate_api_key(api_key: str, logger = None) -> bool:
if not api_key.startswith('sky-'):
log_error_log(SkyflowMessages.ErrorLogs.INVALID_API_KEY.value, logger=logger)
return False

if len(api_key) != 42:
log_error_log(SkyflowMessages.ErrorLogs.INVALID_API_KEY.value, logger = logger)
return False
api_key_pattern = re.compile(r'^sky-[a-zA-Z0-9]{5}-[a-fA-F0-9]{32}$')

return bool(api_key_pattern.match(api_key))
return True

def validate_credentials(logger, credentials, config_id_type=None, config_id=None):
key_present = [k for k in ["path", "token", "credentials_string", "api_key"] if credentials.get(k)]
Expand Down
Loading