Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions skyflow/service_account/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from skyflow.error import SkyflowError
from skyflow.generated.rest.models import V1GetAuthTokenRequest
from skyflow.service_account.client.auth_client import AuthClient
from skyflow.utils.logger import log_error, log_info, log_error_log, Logger
from skyflow.utils.logger import log_info, log_error_log
from skyflow.utils import get_base_url, format_scope, SkyflowMessages


Expand Down Expand Up @@ -115,18 +115,18 @@ def get_signed_jwt(options, client_id, key_id, token_uri, private_key, logger):

def get_signed_tokens(credentials_obj, options):
try:
expiry_time = time.time() + options.get("time_to_live", 60)
expiry_time = int(time.time()) + options.get("time_to_live", 60)
prefix = "signed_token_"

if options and options.get("data_tokens"):
for token in options["data_tokens"]:
claims = {
"iss": "sdk",
"key": credentials_obj.get("keyID"),
"aud": credentials_obj.get("tokenURI"),
"exp": expiry_time,
"sub": credentials_obj.get("clientID"),
"tok": token
"tok": token,
"iat": int(time.time()),
}

if "ctx" in options:
Expand Down
16 changes: 15 additions & 1 deletion skyflow/vault/controller/_vault.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
V1DetokenizePayload, V1TokenizeRecordRequest, V1TokenizePayload, QueryServiceExecuteQueryBody, \
RecordServiceBulkDeleteRecordBody, RecordServiceUpdateRecordBody, RecordServiceBatchOperationBody, V1BatchRecord, \
BatchRecordMethod
from skyflow.generated.rest.exceptions import BadRequestException, UnauthorizedException
from skyflow.generated.rest.exceptions import BadRequestException, UnauthorizedException, ForbiddenException
from skyflow.utils import SkyflowMessages, parse_insert_response, \
handle_exception, parse_update_record_response, parse_delete_response, parse_detokenize_response, \
parse_tokenize_response, parse_query_response, parse_get_response, encode_column_values
Expand Down Expand Up @@ -105,6 +105,8 @@
handle_exception(e, self.__vault_client.get_logger())
except UnauthorizedException as e:
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 109 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L108-L109

Added lines #L108 - L109 were not covered by tests

def update(self, request: UpdateRequest):
log_info(SkyflowMessages.Info.VALIDATE_UPDATE_REQUEST.value, self.__vault_client.get_logger())
Expand Down Expand Up @@ -132,6 +134,8 @@
handle_exception(e, self.__vault_client.get_logger())
except UnauthorizedException as e:
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 138 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L137-L138

Added lines #L137 - L138 were not covered by tests

def delete(self, request: DeleteRequest):
log_info(SkyflowMessages.Info.VALIDATING_DELETE_REQUEST.value, self.__vault_client.get_logger())
Expand All @@ -157,6 +161,8 @@
log_error_log(SkyflowMessages.ErrorLogs.DELETE_REQUEST_REJECTED.value,
logger=self.__vault_client.get_logger())
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 165 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L164-L165

Added lines #L164 - L165 were not covered by tests

def get(self, request: GetRequest):
log_info(SkyflowMessages.Info.VALIDATE_GET_REQUEST.value, self.__vault_client.get_logger())
Expand Down Expand Up @@ -190,6 +196,8 @@
except UnauthorizedException as e:
log_error_log(SkyflowMessages.ErrorLogs.GET_REQUEST_REJECTED.value, self.__vault_client.get_logger())
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 200 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L199-L200

Added lines #L199 - L200 were not covered by tests

def query(self, request: QueryRequest):
log_info(SkyflowMessages.Info.VALIDATING_QUERY_REQUEST.value, self.__vault_client.get_logger())
Expand All @@ -213,6 +221,8 @@
except UnauthorizedException as e:
log_error_log(SkyflowMessages.ErrorLogs.QUERY_REQUEST_REJECTED.value, self.__vault_client.get_logger())
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 225 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L224-L225

Added lines #L224 - L225 were not covered by tests

def detokenize(self, request: DetokenizeRequest):
log_info(SkyflowMessages.Info.VALIDATE_DETOKENIZE_REQUEST.value, self.__vault_client.get_logger())
Expand Down Expand Up @@ -241,6 +251,8 @@
log_error_log(SkyflowMessages.ErrorLogs.DETOKENIZE_REQUEST_REJECTED.value,
logger=self.__vault_client.get_logger())
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 255 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L254-L255

Added lines #L254 - L255 were not covered by tests

def tokenize(self, request: TokenizeRequest):
log_info(SkyflowMessages.Info.VALIDATING_TOKENIZE_REQUEST.value, self.__vault_client.get_logger())
Expand Down Expand Up @@ -270,3 +282,5 @@
log_error_log(SkyflowMessages.ErrorLogs.TOKENIZE_REQUEST_REJECTED.value,
logger=self.__vault_client.get_logger())
handle_exception(e, self.__vault_client.get_logger())
except ForbiddenException as e:
handle_exception(e, self.__vault_client.get_logger())

Check warning on line 286 in skyflow/vault/controller/_vault.py

View check run for this annotation

Codecov / codecov/patch

skyflow/vault/controller/_vault.py#L285-L286

Added lines #L285 - L286 were not covered by tests
Loading