Skip to content

SK-1407: add pull request template #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skyflow-amith wants to merge 1 commit into from
Closed

SK-1407: add pull request template #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
Start with a concise summary of the PR. The first three sections are required. The questions present in each section is there to help you guide you what to add. They are meant to be overwritten by your comments.
## Why
- Why are you making the change?
- What is the underlying issue that you are trying to case, in case of fix?
- Why is it needed by the feature you are working on?
- What is the intent behind making the change?

## Goal
- What is the intended outcome?
- What part of the feature should start working?
- What are the non-goals or will be covered in future PR?

## Testing
- How was the code tested?
- If you haven't written unit tests, why?
- What more testing is needed? Do you intend to manually test it after deployment?
- Do you have any concerns if this changed is released to prod?

## Tech debt
- Is the PR adding to tech debt in any way?
- Are you addressing some Tech debt in this PR?
- If both the above are false, feel free to remove this section.
Loading