Skip to content

SK-1900 Improve debugging errors in connections #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyflow-vivek merged 1 commit into from
Feb 28, 2025
Merged

SK-1900 Improve debugging errors in connections #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/main/java/com/skyflow/errors/SkyflowException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,18 @@
super(cause);
this.httpCode = httpCode;
setRequestId(responseHeaders);
setResponseBody(responseBody);
setResponseBody(responseBody, responseHeaders);
}

private void setResponseBody(String responseBody) {
private void setResponseBody(String responseBody, Map<String, List<String>> responseHeaders) {
try {
if (responseBody != null) {
this.responseBody = JsonParser.parseString(responseBody).getAsJsonObject();
if (this.responseBody.get("error") != null) {
setGrpcCode();
setHttpStatus();
setMessage();
setDetails();
setDetails(responseHeaders);
}
}
} catch (JsonSyntaxException e) {
Expand Down Expand Up @@ -86,9 +86,19 @@
this.httpStatus = statusElement == null ? null : statusElement.getAsString();
}

private void setDetails() {
private void setDetails(Map<String, List<String>> responseHeaders) {
JsonElement detailsElement = ((JsonObject) responseBody.get("error")).get("details");
this.details = detailsElement == null ? null : detailsElement.getAsJsonArray();
List<String> errorFromClientHeader = responseHeaders.get("error-from-client");
if (detailsElement != null) {
this.details = detailsElement.getAsJsonArray();
}
if (errorFromClientHeader != null) {
this.details = this.details == null ? new JsonArray() : this.details;
String errorFromClient = errorFromClientHeader.get(0);
JsonObject detailObject = new JsonObject();
detailObject.addProperty("errorFromClient", errorFromClient);
this.details.add(detailObject);

Check warning on line 100 in src/main/java/com/skyflow/errors/SkyflowException.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/errors/SkyflowException.java#L97-L100 

Added lines #L97 - L100 were not covered by tests
}
}

public int getHttpCode() {
Expand Down
Loading