Skip to content

Conversation

@skyflow-vivek
Copy link
Collaborator

This PR addresses feedback for insert and detokenize methods SDK responses when continueOnError flag is true.

Why

  • When continueOnError flag is set to true, requestId is not present for failed requests.
  • The absence of requestId makes it difficult to debug and troubleshoot these failed requests effectively.

Goal

  • requestId will be present for detokenize failure responses when continueOnError is true
  • requestId will be present for insert failure responses when continueOnError is true

Testing

  • The changes were tested manually.
  • Modified unit tests to check for presence of requestId in failed request responses when continueOnError is true

- Add requestId for detokenize failure responses when continueOnError is true
- Add requestId for insert failure responses when continueOnError is true
@skyflow-vivek skyflow-vivek merged commit b6b25c8 into release/25.2.1 Feb 20, 2025
2 of 4 checks passed
@skyflow-shravan skyflow-shravan deleted the SK-1890-include-request-ids-in-response-for-continue-on-error-failure-cases branch June 18, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants