SK-1875 Add separate redaction types for tokens in Detokenize #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amith-skyflow
approved these changes
Feb 13, 2025
saileshwar-skyflow
approved these changes
Feb 13, 2025
skyflow-shravan
approved these changes
Feb 13, 2025
- Update error messages and logs according to changes - Update detokenize sample to work with new changes
skyflow-vivek
force-pushed
the
SK-1875-support-separate-redaction-type-for-each-token-in-detokenize-method
branch
from
5978ddb to
fe43c66
Compare
amith-skyflow
approved these changes
Feb 13, 2025
skyflow-shravan
deleted the
SK-1875-support-separate-redaction-type-for-each-token-in-detokenize-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the creation of payload for
detokenizemethod according to received feedback.Why
tokenswere getting detokenized with same redaction type provided in request payload.tokenshould be allowed to be detokenized with its own redaction type.Goal
tokenin request payload can specify its own redaction type, which is more closer to actual API designTesting