Skip to content

Conversation

@skyflow-vivek
Copy link
Collaborator

This PR contains fixes for inconsistencies found in Java SDK w.r.t other server-side SDKs. It also contains unit tests for fixed scenarios as well as previously uncovered scenarios, along with changes in workflow to properly run newly added unit tests.

Why

  • Inconsistencies in Java SDK w.r.t server-side SDKs needs to be addressed.
  • These changes not only fix inconsistencies, but also helps in implementing robust assertions in E2E tests.

Goal

  • Inconsistencies in Java SDK w.r.t server-side SDKs should be fixed.
  • Overall unit tests coverage should increase.

Testing

  • Manual testing for all scenarios and inconsistency fixes were done.
  • Additional unit tests were added to cover scenarios more thoroughly

@skyflow-vivek skyflow-vivek merged commit e63cc93 into v2 Dec 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants