Skip to content

SK-2464: add linter to GO sdk v2 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skyflow-himanshu wants to merge 3 commits into
base: main
Choose a base branch
from
+48 −0
Open

SK-2464: add linter to GO sdk v2 #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d217489
SK-2464: add linter to GO sdk v2
skyflow-himanshu Jan 16, 2026
2333209
SK-2464: fix configuration for linter failing in ci
skyflow-himanshu Jan 16, 2026
2d201e2
SK-2464: fix linter var-naming failing in ci
skyflow-himanshu Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ jobs:
with:
go-version: 1.21

- name: Run golangci-lint for v2
uses: golangci/golangci-lint-action@v9
with:
version: v2.8.0
working-directory: v2
args: --config=.golangci.yml --timeout=5m

- name: create-json
id: create-json
uses: jsdaniell/create-json@1.1.2
Expand Down
37 changes: 37 additions & 0 deletions v2/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
version: "2"

run:
timeout: 5m
tests: false
relative-path-mode: gomod

linters:
default: none
enable:
- revive
exclusions:
paths:
- internal/generated
- test

settings:
revive:
enable-all-rules: false
enable-default-rules: false
rules:
- name: var-naming
arguments:
- ["ID", "URL", "API", "HTTP", "JSON", "UUID"]
- []
- - upper-case-const: true
skip-package-name-checks: true
- name: receiver-naming

- name: exported
disabled: true
- name: package-comments
disabled: true
- name: dot-imports
disabled: true
- name: indent-error-flow
disabled: true
4 changes: 4 additions & 0 deletions v2/utils/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ const (
Gender DetectEntities = "gender"
HealthcareNumber DetectEntities = "healthcare_number"
Injury DetectEntities = "injury"
//revive:disable-next-line:var-naming
IpAddress DetectEntities = "ip_address"
Language DetectEntities = "language"
Location DetectEntities = "location"
Expand Down Expand Up @@ -423,11 +424,13 @@ type DetokenizeResponse struct {

type DeleteRequest struct {
Table string
//revive:disable-next-line:var-naming
Ids []string
}

type DeleteResponse struct {
// Response fields
//revive:disable-next-line:var-naming
DeletedIds []string
Errors []map[string]interface{}
}
Expand All @@ -449,6 +452,7 @@ type UpdateResponse struct {

type GetRequest struct {
Table string
//revive:disable-next-line:var-naming
Ids []string
}
type GetOptions struct {
Expand Down
Loading