Use the wasm version of the skycoin-lite lib#570
Merged
gz-c merged 10 commits intoskycoin:developfrom Jul 19, 2019
Merged
Conversation
Collaborator
Author
|
The last commit includes an updated version of the wasm lib and the changes needed for making the tests to run. However, the PR for adding the wasm version to Skycoin-lite is still pending, so more changes could be needed later. |
Member
|
merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The GopherJS version of skycoin-lite was replaced with the wasm version.
The tests have been updated.
The code now is much better at checking if the library was loaded successfully.
The compiled skycoin-lite wasm file was added to the repo, but the idea is to load it dinamically as a dependency after merging Prepare for creating wasm builds skycoin-lite#32
It does not work in Android, but apparently the problem will be solved in Go v1.13 (https://go-review.googlesource.com/c/go/+/170950/ ) and the GopherJS version was too slow to be usable anyway