[M2] Add deadlines to Transport.#32
Open
nkryuchkov wants to merge 27 commits intoskycoin:mainnet-milestone2from
Open
[M2] Add deadlines to Transport.#32nkryuchkov wants to merge 27 commits intoskycoin:mainnet-milestone2from
nkryuchkov wants to merge 27 commits intoskycoin:mainnet-milestone2from
Conversation
nkryuchkov
changed the title
evanlinjin
suggested changes
Aug 15, 2019
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Looks mostly good. Just skimmed through it briefly.
evanlinjin
suggested changes
Aug 16, 2019
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
My recommendation is to have deadline implemented with all the following member functions:
Close()SetDeadline(t time.Time)Serve()DeadlineExceeded() boolDeadlineCh() <-chan struct
This can improve readability and testability.
evanlinjin
suggested changes
Aug 18, 2019
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Please review my comments.
We probably also need a deadline_test.go for ensuring that it is completely thread-safe.
evanlinjin
suggested changes
Aug 19, 2019
|
@nkryuchkov Please resolve conflicts. Thank you! |
…re/transport-deadline # Conflicts: # server_test.go # transport.go
Collaborator
Author
|
@evanlinjin done |
evanlinjin
changed the base branch from
mainnet-milestone1
to
mainnet-milestone2
evanlinjin
changed the title
evanlinjin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Changes:
SetReadDeadlineSetWriteDeadlineSetDeadline