This repository was archived by the owner on Sep 10, 2025. It is now read-only.
fix: Persist the HTTP-headers, used for caching, to disk#141
Merged
Conversation
In the past we tried to save the HTTP-headers which we returned to an in-memory cache (i.e. map), so that on all HTTP-requests after the first we could use them to minimize load on our remote feeds. However we did not _persist_ the headers, so that meant on startup we'd always make one unconditional HTTP-fetch against each configured feed. This pull-request saves the values we've received and uses them on startup, and future updates. This should close #140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past we tried to save the HTTP-headers which we returned to an in-memory cache (i.e. map), so that on all HTTP-requests after the first we could use them to minimize load on our remote feeds.
However we did not persist the headers, so that meant on startup we'd always make one unconditional HTTP-fetch against each configured feed.
This pull-request saves the values we've received and uses them on startup, and future updates.
This should close #140.