Skip to content

#48 Remove lyrics header information from the result for Genius provider #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skuill merged 1 commit into from
Apr 5, 2025
Merged

#48 Remove lyrics header information from the result for Genius provider #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions LyricsScraperNET/Providers/Genius/GeniusProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ public sealed class GeniusProvider : ExternalProviderBase
// Format: "artist song". Example: "Parkway Drive Carrion".
private const string GeniusSearchQueryFormat = "{0} {1}";

// Lyrics header. Note: Should be skipped in result
private const string _lyricsHeaderNodesXPath = "//div[contains(@class, 'LyricsHeader')]";

private const string _referentFragmentNodesXPath = "//a[contains(@class, 'ReferentFragmentVariantdesktop') or contains(@class, 'ReferentFragmentdesktop') or contains(@class, 'ReferentFragment-desktop')]";
private const string _lyricsContainerNodesXPath = "//div[@data-lyrics-container]";

Expand Down Expand Up @@ -179,6 +182,12 @@ private string GetParsedLyricFromHtmlPageBody(string htmlPageBody, out bool inst
foreach (HtmlNode spanNode in spanNodes)
spanNode.Remove();

// Lyric's header node with additional information should be skipped.
var lyricsHeaderNodes = htmlDocument.DocumentNode.SelectNodes(_lyricsHeaderNodesXPath);
if (lyricsHeaderNodes != null)
foreach (HtmlNode headerNode in lyricsHeaderNodes)
headerNode.Remove();

var lyricNodes = htmlDocument.DocumentNode.SelectNodes(_lyricsContainerNodesXPath);
if (lyricNodes == null)
{
Expand Down
Loading
Loading