Skip to content

[MNT] migrate test-deps-2025 to use uv date cutoffs#2055

Open
RUPESH-KUMAR01 wants to merge 8 commits intosktime:mainfrom
RUPESH-KUMAR01:main
Open

[MNT] migrate test-deps-2025 to use uv date cutoffs#2055
RUPESH-KUMAR01 wants to merge 8 commits intosktime:mainfrom
RUPESH-KUMAR01:main

Conversation

@RUPESH-KUMAR01
Copy link

@RUPESH-KUMAR01 RUPESH-KUMAR01 commented Feb 16, 2026

Reference Issues/PRs

Fixes #2054
Related: sktime/sktime#9383

What does this implement/fix? Explain your changes.

Replaces the explicit dependency set with uv’s UV_EXCLUDE_NEWER to install dependencies from a time-frozen snapshot.

What should a reviewer concentrate their feedback on?

Correct usage of UV_EXCLUDE_NEWER for timestamp regression testing

Cutoff date choice (2025-01-01) and whether it matches project expectations

Did you add any tests for the change?

No new tests added, as this change only affects CI configuration.

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@602ee15). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2055   +/-   ##
=======================================
  Coverage        ?   86.63%           
=======================================
  Files           ?      165           
  Lines           ?     9732           
  Branches        ?        0           
=======================================
  Hits            ?     8431           
  Misses          ?     1301           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.63% <ø> (?)
pytest 86.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RUPESH-KUMAR01
Copy link
Author

The cutoff date was set to 2025-10-10 to maintain compatibility with skbase. Earlier dates resolved to versions that did not include _safe_import, which led to test collection errors. The cutoff date was therefore chosen based on dependency compatibility.

@phoeenniixx phoeenniixx added the maintenance Continuous integration, unit testing & package distribution label Feb 19, 2026
@phoeenniixx
Copy link
Member

FYI @fkiraly, please have a look at this!

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - scikit-base has no dependencies itself.

Is there a way to make 2024 and 2025 timestamps apply for all other packages except scikit-base, but keeping scikit-base at the newest possible version?

@RUPESH-KUMAR01
Copy link
Author

RUPESH-KUMAR01 commented Feb 24, 2026

Hi @fkiraly,
The tests will now run with scikit-base at the latest version, while the rest of the packages will use a cutoff date of 2025-01-01. Please let me know if we should choose a different cutoff date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] migrate test-deps-2025 to use uv date cutoffs

3 participants