[MNT] migrate test-deps-2025 to use uv date cutoffs#2055
[MNT] migrate test-deps-2025 to use uv date cutoffs#2055RUPESH-KUMAR01 wants to merge 8 commits intosktime:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2055 +/- ##
=======================================
Coverage ? 86.63%
=======================================
Files ? 165
Lines ? 9732
Branches ? 0
=======================================
Hits ? 8431
Misses ? 1301
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The cutoff date was set to 2025-10-10 to maintain compatibility with skbase. Earlier dates resolved to versions that did not include _safe_import, which led to test collection errors. The cutoff date was therefore chosen based on dependency compatibility. |
|
FYI @fkiraly, please have a look at this! |
fkiraly
left a comment
There was a problem hiding this comment.
I see - scikit-base has no dependencies itself.
Is there a way to make 2024 and 2025 timestamps apply for all other packages except scikit-base, but keeping scikit-base at the newest possible version?
|
Hi @fkiraly, |
Reference Issues/PRs
Fixes #2054
Related: sktime/sktime#9383
What does this implement/fix? Explain your changes.
Replaces the explicit dependency set with uv’s UV_EXCLUDE_NEWER to install dependencies from a time-frozen snapshot.
What should a reviewer concentrate their feedback on?
Correct usage of UV_EXCLUDE_NEWER for timestamp regression testing
Cutoff date choice (2025-01-01) and whether it matches project expectations
Did you add any tests for the change?
No new tests added, as this change only affects CI configuration.
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files