Fix device_tracker_timeout example config#612
Fix device_tracker_timeout example config#612scaccoman wants to merge 1 commit intoskrashevich:mainfrom
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
README.md (1)
439-442: Consider adjusting comment formatting for consistency.The comment formatting could be improved to match the style of other configuration options in the file:
- # By adjusting device_tracker_timeout , users can determine how long they - # want to wait before receiving a 'not_home' message when no person is - # recognized. The time delay is implemented in minutes and the default value - # is set to 30 minutes + # By adjusting device_tracker_timeout, users can determine how long they + # want to wait before receiving a 'not_home' message when no person is + # recognized. The time delay is implemented in minutes and the default value + # is set to 30 minutes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
README.md(1 hunks)
🔇 Additional comments (1)
README.md (1)
436-444: LGTM! Configuration option correctly placed under frigate section.
The device_tracker_timeout option is now properly documented and correctly placed at the root level of the frigate configuration section, which matches how it's used in the codebase.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Hey @skrashevich, this should be a dead simple PR to merge, there's a mistake in the docs which may cost users a ton of time and frustration in the future (like to me). I had to dig into the codebase to figure out why |
|
Hi @scaccoman @skrashevich (@jakowenko), is there a other know maintainer for this in the meantime? I would really love to contribute to this :) But it seems the double-take is a little stale. Let me know. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Commenting to keep PR open |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Fix indentation of
device_tracker_timeoutproperty in example config in README.As you can see from the relevant code below,
device_tracker_timeoutis not nested inside theeventsproperty:Summary by CodeRabbit
New Features
device_tracker_timeout, allowing users to customize the delay for the MQTT home assistant device tracker.Documentation
README.mdto include the new configuration option and improved clarity of comments related to its purpose and default value.