Print nested arrays for logged recognition output#597
Print nested arrays for logged recognition output#597djak250 wants to merge 1 commit intoskrashevich:mainfrom
Conversation
JSON.stringify the loggedOutput object to keep helpful information like `box` and `checks` in the logs
WalkthroughThe recent changes enhance the logging functionality in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- api/src/controllers/recognize.controller.js (1 hunks)
Files skipped from review due to trivial changes (1)
- api/src/controllers/recognize.controller.js
|
At present, the logs are lacking some important information for events due to JS not deeply printing the object. info: {
id: 'c28a...17',
duration: 0.18,
timestamp: '2024-08-05T18:20:08.803Z',
attempts: 1,
camera: 'manual',
zones: [],
counts: { person: 1, match: 0, miss: 0, unknown: 1 },
matches: [],
misses: [],
unknowns: [
{
name: 'unknown',
confidence: 0,
match: false,
box: [Object], /// Here
checks: [Array], /// and Here
type: 'manual',
duration: 0.15,
detector: 'aiserver',
filename: '66c6..3b10.jpg'
}
]
} |
|
Logs after this change info: {
"id": "1722...du",
"duration": 17.15,
"timestamp": "2024-08-05T19:07:21.418Z",
"attempts": 18,
"camera": "south",
"zones": [
"garage"
],
"counts": {
"person": 0,
"match": 0,
"miss": 0,
"unknown": 0
},
"matches": [],
"misses": [],
"unknowns": [
{
"name": "unknown",
"confidence": 0,
"match": false,
"box": { /// Helpful information
"top": 63,
"left": 180,
"width": 36,
"height": 54
},
"checks": [
"confidence too low: 0 < 40" /// Now I know why it didn't match
],
"type": "snapshot",
"duration": 0.13,
"detector": "aiserver",
"filename": "953e...fb00.jpg"
}
]
} |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@skrashevich Any thoughts about merging this? |
Please, rebase to beta branch |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
JSON.stringify the loggedOutput object to keep helpful information like
boxandchecksin the logsSummary by CodeRabbit