-
Notifications
You must be signed in to change notification settings - Fork 0
Updating Drupal example to match current standards #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84ec9da to
832654f
Compare
…s with docker-compose. Updating images and username/password pairs
| defaults: | ||
| run: | ||
| working-directory: ./drupal | ||
| steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not using the gh-workflows because it needs to set the working directory. And I can't do that easily without updating those workflows.
nickschuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit other it's all good
Consolidate approach to end to end testing for the entire Drupal stack.
This will allow us to run latest Drupal with the latest container images on the latest Skpr infrastructure more easily, along with integrating our specific functionality like
skpr_logs, clamav and OpenSearch. Should consider a standard approach to Valkey too for testing.Follow up changes will be (not this week):