Open
Conversation
skitterm
commented
Mar 9, 2024
Comment on lines
-35
to
-47
| public async componentDidMount() { | ||
| const id = '6015aa416131eb0a74e89e52' | ||
| // get the first user... return that for now | ||
| try { | ||
| const userResponse = await fetch(`/users/${id}`); | ||
| if (userResponse.status !== 200) { | ||
| throw new Error(userResponse.statusText); | ||
| } | ||
| const user = await userResponse.json(); | ||
| this.setState({ user }); | ||
| } catch(err) { | ||
| console.error('Unable to find user'); | ||
| } |
Owner
Author
There was a problem hiding this comment.
This isn't needed for now.
skitterm
commented
Mar 9, 2024
Comment on lines
+32
to
+44
| public async componentDidMount() { | ||
| const url = new URL(window.location.href); | ||
| const userId = url.searchParams.get("userId"); | ||
| if (userId) { | ||
| const userResponse = await fetch("/users"); | ||
| const users = (await userResponse.json()) as User[]; | ||
| const user = users.find((item) => { | ||
| return item._id === userId; | ||
| }); | ||
| if (user) { | ||
| this.props.onUserSelected(user); | ||
| this.props.history.push("/messages"); | ||
| } |
Owner
Author
There was a problem hiding this comment.
Now we load the data at the page-level instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that all production-specific considerations like CI, security, tier-specific logging, and so forth are addressed.