Skip to content

Prevent embedded ads for first members by always logging in#2

Open
ch-rs wants to merge 1 commit intoskipmodea1:masterfrom
ch-rs:patch-1
Open

Prevent embedded ads for first members by always logging in#2
ch-rs wants to merge 1 commit intoskipmodea1:masterfrom
ch-rs:patch-1

Conversation

@ch-rs
Copy link
Copy Markdown
Contributor

@ch-rs ch-rs commented May 5, 2023

Hi @skipmodea1!

I've started seeing ads for some videos, which must be embedded in the streams now.

From what I gather, we currently skip the login step for public videos, only logging in when the video is first member only. I suggest we now log in every time so that first members don't get the ad version of the steam.

I removed the entire condition...

if must_login_first_member_user:

...but you might think it cleaner to simply set must_login_first_member_user to true prior to that.

                if html_source.find("not yet available") >= 0:
                    # let's try and get this non-first_member video after login in the first_member user then
                    must_login_first_member_user = True
                    video_is_not_yet_available = True
                else:
                    must_login_first_member_user = False
                    video_is_not_yet_available = False

I've tested this on Kodi for MacOS and two of my Vero 4K boxes—all running OSMC.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant