Implementation of Issue #133#134
Open
manulaiko wants to merge 2 commits intoskandasoft:masterfrom
manulaiko:master
Open
Implementation of Issue #133#134manulaiko wants to merge 2 commits intoskandasoft:masterfrom manulaiko:master
manulaiko wants to merge 2 commits intoskandasoft:masterfrom
manulaiko:master
Conversation
*http://localhost/* does not redirects to *http://127.0.0.1/* and it can be any name that doesn't contains a domain/subdomain.
*http://localhost/* does not redirects to *http://127.0.0.1/* and it can be any name that doesn't contains a domain/subdomain.
Pyragon
approved these changes
Apr 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of issue #133
Although now any URL that matches http://([a-zA-Z0-9]*)/ is now treated as localhost, you can still configure hosts file to point any name with sub-domains to 127.0.0.1 but they will not be recognized as localhost and they will result in a google search.
This could be fixed by assuming that if the URL ends with /, it's a localhost, or by actually checking that the URL translates to 127.0.0.1