Fix skale passive node options #953
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the passive node management logic, primarily focusing on how Docker service versions are handled and how service definitions are composed. The most significant changes involve removing the dependency on the
DOCKER_LVMPY_VERSIONenvironment variable for passive updates, updating the meta data structure to allow forNonevalues, and streamlining the definition of passive compose services.Passive node update logic and metadata:
update_passivefunction no longer sets theDOCKER_LVMPY_VERSIONin the meta update, passingNoneinstead. This removes the requirement for this environment variable during passive updates.CliMetadataclass now allowsdocker_lvmpy_versionto beNone, making the metadata structure more flexible and accommodating the above change.Docker compose service definitions:
BASE_PASSIVE_COMPOSE_SERVICESdictionary now includes all items fromREDIS_SERVICE_DICTin addition to the existing services, simplifying and centralizing service definitions.Submodule update:
helper-scriptssubmodule has been updated to a new commit, likely bringing in upstream improvements or fixes.