Skip to content

Conversation

@dmytrotkk
Copy link
Collaborator

This pull request makes several updates to the passive node management logic, primarily focusing on how Docker service versions are handled and how service definitions are composed. The most significant changes involve removing the dependency on the DOCKER_LVMPY_VERSION environment variable for passive updates, updating the meta data structure to allow for None values, and streamlining the definition of passive compose services.

Passive node update logic and metadata:

  • The update_passive function no longer sets the DOCKER_LVMPY_VERSION in the meta update, passing None instead. This removes the requirement for this environment variable during passive updates.
  • The CliMeta dataclass now allows docker_lvmpy_version to be None, making the metadata structure more flexible and accommodating the above change.

Docker compose service definitions:

  • The BASE_PASSIVE_COMPOSE_SERVICES dictionary now includes all items from REDIS_SERVICE_DICT in addition to the existing services, simplifying and centralizing service definitions.

Submodule update:

  • The helper-scripts submodule has been updated to a new commit, likely bringing in upstream improvements or fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants