SPP1-189: Make TestS3ChunkStore more flexible#391
Open
ludwigschwardt wants to merge 1 commit intomasterfrom
Open
SPP1-189: Make TestS3ChunkStore more flexible#391ludwigschwardt wants to merge 1 commit intomasterfrom
ludwigschwardt wants to merge 1 commit intomasterfrom
Conversation
It is convenient to start a local S3 server using `TestS3ChunkStore`. I use this to benchmark Zarr, for example. It would be nice to open buckets with anonymous read support as they are on the real archive. This enables the Zarr HTTP filesystem backend (instead of s3fs), a lighter interface with simple support for our bearer tokens. The `public_read` parameter to `S3ChunkStore` does this, and is passed into `TestS3ChunkStore.prepare_store_args` within the `setup_class` call. Make it possible to add more parameters this way, by adding `**kwargs` to `setup_class`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is convenient to start a local S3 server using
TestS3ChunkStore. I use this to benchmark Zarr, for example. It would be nice to open buckets with anonymous read support as they are on the real archive. This enables the Zarr HTTP filesystem backend (instead of s3fs), a lighter interface with simple support for our bearer tokens.The
public_readparameter toS3ChunkStoredoes this, and is passed intoTestS3ChunkStore.prepare_store_argswithin thesetup_classcall. Make it possible to add more parameters this way, by adding**kwargstosetup_class.