Skip to content

Conversation

@deyazoubi
Copy link
Collaborator

@deyazoubi deyazoubi commented Feb 6, 2020

add new rule

  • the rule is tested, results can be seen in stepnames 039_Fastqc

two issues have to solve

  1. lines

    directory("{prefix}%s%s/{run}/determined/fastqc/Keimbahn/" % (config['dirs']['intermediate'], config['stepnames']['Fastqc']))
    and
    inp=directory("%s%s%s/{run}/determined/fastqc/Keimbahn/" % (config['dirs']['prefix'],config['dirs']['intermediate'], config['stepnames']['Fastqc'])),

    Sample_Project must be variable for different project

  2. after solve the point 1, for AG_remke the new rule will not work
    the reason is

    def get_samples(samplesheets, config):

    in this function # "only consider samples that have some spike_entity_role defined" and this not the case for AG_remke
    one solutions is
    def get_samples_all(samplesheets, config):

@deyazoubi deyazoubi requested a review from sjanssen2 February 10, 2020 10:18
@sjanssen2
Copy link
Owner

please ping me when the tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants