VPC Pair 4.x Implementation by sivakasi-cisco · Pull Request #1 · sivakasi-cisco/ansible-nd

sivakasi-cisco · 2026-02-09T17:57:57Z

Summary

This PR implements the VPC Pair management module for ND 4.x with comprehensive Pydantic validation.

Changes

Added nd_manage_vpc_pair module for VPC pair lifecycle management
Implemented Pydantic models for input validation
Added common utilities:
- common/log.py: File-based logging for debugging
- common/models.py: Pydantic model helper functions
Module supports states: query, present, absent, merged, replaced, overridden, deleted
Includes deploy and dry_run options

Files Changed

plugins/modules/nd_manage_vpc_pair.py (1,912 lines)
plugins/module_utils/manage/vpc_pair/model_playbook_vpc_pair.py (658 lines)
plugins/module_utils/manage/vpc_pair/__init__.py (90 lines)
plugins/module_utils/common/log.py (369 lines)
plugins/module_utils/common/models.py (111 lines)
plugins/module_utils/nd.py (61 lines modified)

Total: +3,200 insertions, -1 deletion across 6 files

commit a7f263d Merge: 4d1a4b0 e4676e0 Author: Neil John <39439797+neiljohn-gh@users.noreply.github.com> Date: Mon Aug 18 16:26:10 2025 +0530 Merge branch 'CiscoDevNet:master' into vpc_peers_module commit 4d1a4b0 Author: neiljohn-gh <neiljohn9125@gmail.com> Date: Mon Aug 18 15:52:51 2025 +0530 added deploy and dry_run options to nd_manage_vpc_pair.py with corresponding functionality and examples commit b8bf64f Author: neiljohn-gh <neiljohn9125@gmail.com> Date: Sun Aug 17 19:24:34 2025 +0530 added merged, overridden, replaced and deleted (WIP) commit 3b46915 Author: neiljohn-gh <neiljohn9125@gmail.com> Date: Tue Jul 29 19:01:57 2025 +0530 added functionality for nd_manage_vpc_pair.py along with the pydantic model required

1. Schema migration 2. 4.x version update on create, update, delete with PUT 3. Field name changes from peer1SwitchId to switchId and switch_id python attribute 4. vpcAction discriminator for PUT EP 5. Update in delete and merged 6. Validation changes

- Add Pydantic-based NDBaseModel for network resource models - Add NDConfigCollection for type-safe config management with O(1) lookups - Add NDNetworkResourceModule base class for network resource modules - Add nd_local_user module as reference implementation - Supports merged/replaced/overridden/deleted states - Implements composition pattern with actions_overwrite_map Co-authored-by: Gaspard Micol <gmicol@cisco.com>

sivakasi-cisco · 2026-02-25T13:59:51Z

+        raise ValueError(f"fabric_name must be a non-empty string. Got: {fabric_name!r}")
+
+    # Initialize RestSend via NDModuleV2
+    nd_v2 = NDModuleV2(nrm.module)


NDModuleV2 is used for vpc_pair module specific custom functions and used above as an argument

sivakasi-cisco · 2026-02-25T14:02:37Z

CReate, Update, Delete, deploy, query_all custom functions use NDModuleV2 custom RestSend path

sivakasi-cisco · 2026-02-26T14:00:59Z

    VpcFieldNames,
 )
 from ansible_collections.cisco.nd.plugins.module_utils.manage.vpc_pair.vpc_pair_endpoints import (
+    EpVpcPairConsistencyGet,


Added missing API usage for vPC support/consistency/list endpoints

sivakasi-cisco · 2026-02-26T14:02:06Z

@@ -888,6 +944,123 @@ def _get_recommendation_details(nd_v2, fabric_name: str, switch_id: str, timeout
        raise




Added endpoint helpers

vpc_pairs_list

switch_vpc_support

switch_vpc_consistency

_extract_vpc_pairs_from_list_response

_get_pairing_support_details

_get_consistency_details

…c_pair_4x

commit df99ff3 Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Feb 26 14:09:18 2026 -0500 [ignore] Make a small change to NDModule request function. commit 9cdfa66 Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Feb 26 14:01:24 2026 -0500 [ignore] Rename NDNetworkResourceModule to NDStateMachine. Add file for NDNestedModel. Add types.file. Various Renaming and small Modifications across the repo. WIP. commit b41b5b8 Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Feb 26 10:44:23 2026 -0500 [ignore] Fix and in nd_config_collections.py. Move to utils.py. commit e2101f9 Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Feb 26 10:42:12 2026 -0500 [ignore] Complete orchestrators/base.py by making simple CRUD operations methods that work for single_identifier strategy (meant to be overridden if needed). commit 48b62be Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Feb 26 10:38:50 2026 -0500 [ignore] Add choice for when no identifier is needed. Add quick comments and changes to models/local_user.py and api_endpoints/base.py commit b04a82b Author: Gaspard Micol <gmicol@cisco.com> Date: Wed Feb 25 08:24:28 2026 -0500 [ignore] Default to none and update condition for regarding in models/base.py. commit 229af5a Author: Gaspard Micol <gmicol@cisco.com> Date: Tue Feb 24 12:57:37 2026 -0500 [ignore] Adapt the Network Resource Module architecture for ND to smart endpoints and Pydantic models modification (works for merge and replace states). Add comments for next steps. commit 4b65c25 Author: Gaspard Micol <gmicol@cisco.com> Date: Wed Feb 18 01:23:37 2026 -0500 [ignore] Modifiy models/local_user to take full advantage of Pydantic built-in functionalities. Slightly modify models/base.py to enforce identifiers definitions in NDBaseModel subclasses. Added multiple notes to assert next steps. commit dead722 Author: Gaspard Micol <gmicol@cisco.com> Date: Tue Feb 17 13:46:10 2026 -0500 [ignore] Add api_endpoints for configuring endpoints and orchestrators for orchestrating crud api operations with model instances and endpoints. commit dc9649e Author: Gaspard Micol <gmicol@cisco.com> Date: Fri Jan 23 14:37:44 2026 -0500 [ignore] Modify nd_local_user based on Pydantic implementation and changes added to NDNetworkResourceModule. commit b35fa8d Author: Gaspard Micol <gmicol@cisco.com> Date: Fri Jan 23 13:51:54 2026 -0500 [ignore] Pydantic Base ND Network Resource Module: Final proposition of core design changing existing methods and adding new ones which will be used in future as a based for ND network resource modules as well as basic error handling and simple docstrings. commit d518bf3 Author: Gaspard Micol <gmicol@cisco.com> Date: Fri Jan 23 13:09:33 2026 -0500 [ignore] Pydantic ND Config Collection: Final proposition of core design changing existing methods and adding new ones which will be used in NDNetworkResourceModule class as well as basic error handling and simple docstrings. commit c4a4da2 Author: Gaspard Micol <gmicol@cisco.com> Date: Fri Jan 23 00:56:49 2026 -0500 [ignore] Pydantic ND base models and local_user models: Final proposition of core design adding new methods which will be used in NDConfigCollection and NDNetworkResourceModule classes as well as basic error handling and simple docstrings. commit fe944d0 Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Jan 22 01:04:05 2026 -0500 [ignore] Pydantic Models: Modify and Clean both local_user.py and base.py based on comments. Add a get method and get_identifier_value function to NDBaseModel. commit 7089148 Author: Gaspard Micol <gmicol@cisco.com> Date: Tue Jan 20 13:17:35 2026 -0500 [ignore] Second Pydantic Implementation: Create a NDBaseModel to be inherited from future class models. Modify class models for local_user. commit a04235c Author: Gaspard Micol <gmicol@cisco.com> Date: Thu Jan 15 11:47:32 2026 -0500 [ignore] First Pydantic implementation: Add Pydantic Models for nd_local_user. commit 2a27f38 Author: Gaspard Micol <gmicol@cisco.com> Date: Tue Aug 19 12:44:17 2025 -0400 [minor_change] Add nd_local_user as a new network resource module for Nexus Dashboard v4.1.0 and higher.

and corresponding integration test refinements.

Cherrypicked from PR172

#1

sivakasi-cisco · 2026-03-10T04:19:29Z

changes continued in CiscoDevNet#197

#1

sivakasi-cisco force-pushed the vpc_pair_4x branch 3 times, most recently from 42969a0 to e6b0609 Compare February 17, 2026 15:39

sivakasi-cisco and others added 6 commits February 17, 2026 21:19

Changes related to

707c62e

1. Schema migration 2. 4.x version update on create, update, delete with PUT 3. Field name changes from peer1SwitchId to switchId and switch_id python attribute 4. vpcAction discriminator for PUT EP 5. Update in delete and merged 6. Validation changes

4.x API updation in delete and recommendation

24092ab

Endpoint architecture, refactored schemas, enums, maxims, other changes

b290f73

Http verb Enum changes

fb6f736

sivakasi-cisco force-pushed the vpc_pair_4x branch from e6b0609 to 6055c96 Compare February 17, 2026 15:49

sivakasi-cisco changed the base branch from master to rest_send_integration February 17, 2026 17:51

sivakasi-cisco added 5 commits February 18, 2026 18:53

Update from PR 172 on adding a new network resource module

c9e7c54

vpc_pair state operation with NwResourceModule

c93d8ae

Using actions_overwrite_map for nd_vpc_pair.py

a07ba07

Intermediate changes

6d52e9f

Enhancing vpc_pair module

31ec7ac

sivakasi-cisco force-pushed the vpc_pair_4x branch 2 times, most recently from b1adc39 to 3b30fce Compare February 19, 2026 09:37

Intermediate changes with enums and structures

253d119

sivakasi-cisco force-pushed the vpc_pair_4x branch from 3b30fce to 253d119 Compare February 19, 2026 09:48

Endpoint class corrections

fb36f04

sivakasi-cisco self-assigned this Feb 20, 2026

sivakasi-cisco added 3 commits February 24, 2026 14:18

Integ test changes initial version

466e2b8

intermediate Integ changes

6ac3f71

Integ test changes

d334afb

sivakasi-cisco commented Feb 25, 2026

View reviewed changes

sivakasi-cisco added 3 commits February 25, 2026 20:06

Importing nested model in module

350b59a

APIs left in modules added

cea6c41

[ignore] ND Network Resource module Framework update from PR172

1fb72cd

sivakasi-cisco commented Feb 26, 2026

View reviewed changes

sivakasi-cisco added 8 commits February 27, 2026 10:53

Merge remote-tracking branch 'upstream/rest_send_integration' into vp…

2ca724a

…c_pair_4x

[ignore] Latest PR 172 changes

a6717de

Refactored vpc_pair changes with NDState machine, endpoint directory, \

ca7298a

and corresponding integration test refinements.

Refactoring to localise APIs in vpc_pair

98f69e2

To move to a different upstream, remvoving the changes that were\

c58ba62

Cherrypicked from PR172

nd42_rest_send: apply rest_send branch changes

036c63d

nd42_smart_endpoints: apply smart endpoints branch changes

e489a0c

sivakasi-cisco added a commit that referenced this pull request Mar 9, 2026

Changes ported from old PR for VPC pair \

1169c00

#1

sivakasi-cisco mentioned this pull request Mar 10, 2026

VPC Pair 4.x Implementation CiscoDevNet/ansible-nd#197

Open

sivakasi-cisco added a commit that referenced this pull request Mar 25, 2026

Changes ported from old PR for VPC pair \

1c1d1ff

#1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VPC Pair 4.x Implementation#1

VPC Pair 4.x Implementation#1
sivakasi-cisco wants to merge 27 commits intorest_send_integrationfrom
vpc_pair_4x

sivakasi-cisco commented Feb 9, 2026

Uh oh!

sivakasi-cisco Feb 25, 2026

Uh oh!

sivakasi-cisco Feb 25, 2026

Uh oh!

sivakasi-cisco Feb 26, 2026

Uh oh!

sivakasi-cisco Feb 26, 2026

Uh oh!

sivakasi-cisco commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -888,6 +944,123 @@ def _get_recommendation_details(nd_v2, fabric_name: str, switch_id: str, timeout
		raise

Conversation

sivakasi-cisco commented Feb 9, 2026

Summary

Changes

Files Changed

Uh oh!

sivakasi-cisco Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

sivakasi-cisco Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

sivakasi-cisco Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

sivakasi-cisco Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

sivakasi-cisco commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant