Add Simpleperf app_profiler options and use --android.simpleperf. #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend commands.simpleperf.start() to support for Simpleperf's general app_profiler options. This allows users to pass options like Simpleperf's -nb flag which skips generating a binary cache i.e. a dumped symbols directory (this is useful when symbols are not needed after profiling or when Simpleperf is failing to create a binary cache). Replace --android.ndk with --android.simpleperf. --android.simpleperf is more flexible as it expects the path directly to the directory containing Simpleperf (whereas --android.ndk expects the directory to the NDK installation, which is then used to find Simpleperf via a hardcoded relative path: simpleperf/app_profiler.py). This is particularly useful when Simpleperf is provided standalone, without the NDK (as is the case with a Simpleperf repack).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 minor changes to Browsertime's Simpleperf profiling in this patch:
Improvement: Extend
commands.simpleperf.start()to support for Simpleperf's general app_profiler options. This allows users to pass options like Simpleperf's -nb flag which skips generating a binary cache i.e. a dumped symbols directory (this is useful when symbols are not needed after profiling or when Simpleperf is failing to create a binary cache).Fix: Replace
--android.ndkwith--android.simpleperf.--android.simpleperfis more flexible as it expects the path directly to the directory containing Simpleperf (whereas--android.ndkexpects the directory to the NDK installation, which is then used to find Simpleperf via a hardcoded relative path:simpleperf/app_profiler.py). This is particularly useful when Simpleperf is provided standalone, without the NDK (as is the case with a Simpleperf repack).