Open
Conversation
Author
|
@mficzel As discussed in Slack, this is a first version of my feature that allows sorting taxonomies. What do you think? sitegeist-taxonomy-sortable.mp4 |
Member
|
Not that sure this is consistent across dimensions. that would be important to me. It will probably have to be implemented again for 9.0 as this is in many aspects a rewrite. |
Author
|
Good point. I checked and it isn't consistent (as it is with nodes in the document tree). But it can be solved checking |
Since all Taxonomy items are nodes, the sortingIndex of the nodes is already respected. Instead of just having an alphabetical sorting by title, we allow sorting taxonomies in the backend module. This is helpful if taxonomies are used e.g. as a filter in the frontend and you explicitly want to sort the items.
lorenzulrich
force-pushed
the
feature/taxonomy-sortable
branch
from
09f4e2b to
c9e537d
Compare
Author
Just to let you know, the current version now sets the sorting index across all dimensions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all Taxonomy items are nodes, the sortingIndex of the nodes is already respected. Instead of just having an alphabetical sorting by title, we allow sorting taxonomies in the backend module. This is helpful if taxonomies are used e.g. as a filter in the frontend and you explicitly want to sort the items.