FEATURE: allow email headers to be set via variable#34
Open
LvckyAPI wants to merge 2 commits intositegeist:1.0from
Open
FEATURE: allow email headers to be set via variable#34LvckyAPI wants to merge 2 commits intositegeist:1.0from
LvckyAPI wants to merge 2 commits intositegeist:1.0from
Conversation
Member
|
Thanks for the PR I totally understand the motivation. The changes you suggest can be added in a project easily where one can also better reflect on wether or not they may cause trouble in the concrete use case. However i admit that this was a very defensive decision and i did not give it that much thought. I wanted to avoid that editors can accidentally create a public email form that can send any email. That is why I made this an opt in feature one has to enable. If you see a way to address the mentioned risks I am willing to reconsider those decisions. Regards Martin |
LvckyAPI
commented
Apr 12, 2024
Author
Todo @LvckyAPI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have built a contact form for a customer.
The reply-to address should correspond to the address that the website user entered as their own in the form.
Unfortunately, we encountered a problem:
With this pull request, I have built in that you can also set the e-mail headers such as: Reply address, sender address, recipient address etc. via variable