Skip to content

FEATURE: Add "id" to field and label #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mficzel merged 1 commit into from
Nov 17, 2023
Merged

FEATURE: Add "id" to field and label #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NodeTypes/Field/Button/Button.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ prototype(Sitegeist.PaperTiger:Field.Button) < prototype(Neos.Neos:ContentCompon
<Neos.Fusion.Form:FieldContainer
field.name={props.name}
>
<Neos.Fusion.Form:Button field.value={props.value}>{props.label}</Neos.Fusion.Form:Button>
<Neos.Fusion.Form:Button field.value={props.value} attributes.id={'field_' + field.name}>{props.label}</Neos.Fusion.Form:Button>
</Neos.Fusion.Form:FieldContainer>
`
}
1 change: 1 addition & 0 deletions NodeTypes/Field/Date/Date.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ prototype(Sitegeist.PaperTiger:Field.Date) < prototype(Neos.Neos:ContentComponen
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/Dropdown/Dropdown.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ prototype(Sitegeist.PaperTiger:Field.Dropdown) < prototype(Neos.Neos:ContentComp
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
>
<Neos.Fusion.Form:Select.Option option.value="" attributes.label={props.emptyLabel}
@if={props.emptyOptionEnabled}/>
Expand Down
2 changes: 1 addition & 1 deletion NodeTypes/Field/Email/Email.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ prototype(Sitegeist.PaperTiger:Field.Email) < prototype(Neos.Neos:ContentCompone
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}

attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/Number/Number.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ prototype(Sitegeist.PaperTiger:Field.Number) < prototype(Neos.Neos:ContentCompon
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/Slider/Slider.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ prototype(Sitegeist.PaperTiger:Field.Slider) < prototype(Neos.Neos:ContentCompon
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/TelephoneNumber/TelephoneNumber.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ prototype(Sitegeist.PaperTiger:Field.TelephoneNumber) < prototype(Neos.Neos:Cont
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/Text/MultiLine/MultiLine.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ prototype(Sitegeist.PaperTiger:Field.Text.MultiLine) < prototype(Neos.Neos:Conte
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/Text/SingleLine/SingleLine.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ prototype(Sitegeist.PaperTiger:Field.Text.SingleLine) < prototype(Neos.Neos:Cont
attributes.oninvalid.@if={props.customErrorMessageEnabled}
attributes.oninput={"this.setCustomValidity('')"}
attributes.oninput.@if={props.customErrorMessageEnabled}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions NodeTypes/Field/Upload/Upload.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ prototype(Sitegeist.PaperTiger:Field.Upload) < prototype(Neos.Neos:ContentCompon
<Sitegeist.FusionForm.Upload:Field.Upload
attributes.required={props.isRequired}
attributes.accept={props.allowedExtensions ? '.' + Array.join(props.allowedExtensions, ',.') : false}
attributes.id={'field_' + field.name}
/>
</Sitegeist.PaperTiger:FieldContainer>
`
Expand Down
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Label.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
prototype(Sitegeist.PaperTiger:Label) < prototype(Neos.Fusion:Component) {
for = null
for.@process.withPrefix = ${value ? 'field_' + value : null}
label = ${q(node).property('label')}
isRequired = ${q(node).property('isRequired')}

Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"license": "GPL-3.0+",
"require": {
"php": ">=8.1",
"neos/neos": "~8.2 || 8.3.x-dev ",
"neos/fusion": "~8.2 || 8.3.x-dev",
"neos/neos": "~8.2 || 9.0.x-dev ",
"neos/fusion": "~8.2 || 9.0.x-dev",
"neos/fusion-form": "~2.0 || dev-master",
"sitegeist/inspectorgadget": "~2.0",
"sitegeist/neos-symfonymailer": "~1.1",
Expand Down