fix: #147 breaking bases' filter menu#147
Open
clemens-holleis wants to merge 1 commit intosissilab:masterfrom
Open
fix: #147 breaking bases' filter menu#147clemens-holleis wants to merge 1 commit intosissilab:masterfrom
clemens-holleis wants to merge 1 commit intosissilab:masterfrom
Conversation
|
Thank you for the fix! I'm sure @sissilab has been contacted by the Obsidian team itself, considering the 1.9.2 Catalyst update completely disabled Image Toolkit because of this very thing. They also only have one commit this year, so if this hasn't been fixed by now I think it's safe to assume this won't get merged. Could you perhaps fork it and submit it as a community plugin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #146
The
.menuclass messes up the bases' menues. Since I was not able to find anyimage toolkitview wheredocument.querySelectorAll('.menu')returned any results I thought the easiest way is to get rid of it.I also could not find any place in the codebase where it is used.
If the
.menuclass is planned to be used later, just give it a less generic name.