Open
Conversation
… dii (file diff_imbalance.py). Introduction of an early stopping criteria (diff_imbalance.py). Implementation of the Langevin dynamic, for the estimation of the error (diff_imbalance.py). Insertion of the calculation of the error with langevin dynamic (causal_graph.py).
5de2d08 to
198ffd4
Compare
…ation of dii (file diff_imbalance.py). Introduction of an early stopping criteria (diff_imbalance.py). Implementation of the Langevin dynamic, for the estimation of the error (diff_imbalance.py). Insertion of the calculation of the error with langevin dynamic (causal_graph.py)." This reverts commit 198ffd4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
It fixes an issue in the forward+backward feature selection algorithms using differentiable information imbalance on GPUs (with Jax). The current behaviour is for the feature selection to fail completely when a single set of feature optimization doesn't work. This bugfix introduces a few proposed fixes:
gradient_clipparameter with optax (that is set to0.0by default), to clip large gradients during the optimization process automatically and prevent gradient explosion. This might help with some numerical instability.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.