fix: pass compound senderID to HandleMessage for Telegram allowlist#325
Open
zenchantlive wants to merge 1 commit intosipeed:mainfrom
Open
fix: pass compound senderID to HandleMessage for Telegram allowlist#325zenchantlive wants to merge 1 commit intosipeed:mainfrom
zenchantlive wants to merge 1 commit intosipeed:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the Telegram channel where messages would get stuck on "Thinking..." when the allowlist used username format (@username). The root cause was a mismatch between the senderID format used in two different allowlist checks within the message handling flow.
Changes:
- Modified Telegram message handler to pass compound senderID ("ID|username") instead of just numeric ID to BaseChannel.HandleMessage, ensuring consistent allowlist matching
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #310 - Telegram messages stuck on Thinking
Root Cause
In pkg/channels/telegram.go:358, HandleMessage was called with only the numeric user ID (e.g., "123456789"). However, the allowlist check in BaseChannel.HandleMessage expects the compound format ("123456789|myusername") to match @username entries.
When the allowlist contained @myusername, the numeric-only ID failed the match and the message was silently dropped after showing "Thinking...".
Fix
Use the pre-computed compound senderID instead of just the numeric ID:
Changes
Testing