Skip to content

fix: pass compound senderID to HandleMessage for Telegram allowlist#325

Open
zenchantlive wants to merge 1 commit intosipeed:mainfrom
zenchantlive:fix/telegram-allowlist
Open

fix: pass compound senderID to HandleMessage for Telegram allowlist#325
zenchantlive wants to merge 1 commit intosipeed:mainfrom
zenchantlive:fix/telegram-allowlist

Conversation

@zenchantlive
Copy link

Fixes Issue #310 - Telegram messages stuck on Thinking

Root Cause

In pkg/channels/telegram.go:358, HandleMessage was called with only the numeric user ID (e.g., "123456789"). However, the allowlist check in BaseChannel.HandleMessage expects the compound format ("123456789|myusername") to match @username entries.

When the allowlist contained @myusername, the numeric-only ID failed the match and the message was silently dropped after showing "Thinking...".

Fix

Use the pre-computed compound senderID instead of just the numeric ID:

  • Before: c.HandleMessage(fmt.Sprintf("%d", user.ID), ...)
  • After: c.HandleMessage(senderID, ...)

Changes

  • pkg/channels/telegram.go: 1 line changed

Testing

  • All pkg/channels tests pass (6 tests)
  • Build compiles successfully

Copilot AI review requested due to automatic review settings February 16, 2026 19:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in the Telegram channel where messages would get stuck on "Thinking..." when the allowlist used username format (@username). The root cause was a mismatch between the senderID format used in two different allowlist checks within the message handling flow.

Changes:

  • Modified Telegram message handler to pass compound senderID ("ID|username") instead of just numeric ID to BaseChannel.HandleMessage, ensuring consistent allowlist matching

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant