feat(linters): Added golangci-lint config & CI job#304
Open
mymmrac wants to merge 5 commits intosipeed:mainfrom
Open
feat(linters): Added golangci-lint config & CI job#304mymmrac wants to merge 5 commits intosipeed:mainfrom
mymmrac wants to merge 5 commits intosipeed:mainfrom
Conversation
Collaborator
|
@Zepan This PR adds Recommendation: Merge. This is infrastructure that pays dividends on every future PR. The roadmap explicitly calls for better CI/CD (volunteer role #5: "AI-Powered CI/CD Optimization"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds golangci-lint config, it's not final and needs tweaking, but it should be a good starting point,
For now most linters are disabled (because we have 2600+ issues currently) and we should enable them as we fix them.