fix: make bot greeting name configurable via bot_name setting#303
Open
AtharvaGurao wants to merge 1 commit intosipeed:mainfrom
Open
fix: make bot greeting name configurable via bot_name setting#303AtharvaGurao wants to merge 1 commit intosipeed:mainfrom
AtharvaGurao wants to merge 1 commit intosipeed:mainfrom
Conversation
The /start greeting in Telegram and the DingTalk reply title were
hardcoded as "PicoClaw". Users who customize their bot's identity
via soul.md still see "Hello! I am PicoClaw" on the first message.
Add a bot_name field to agents.defaults config (default: "PicoClaw")
so all channels use the configured name instead of a hardcoded string.
Config example:
{"agents": {"defaults": {"bot_name": "MyBot"}}}
Or via environment variable:
PICOCLAW_AGENTS_DEFAULTS_BOT_NAME=MyBot
Closes sipeed#288
lukemilby
suggested changes
Feb 17, 2026
Comment on lines
+55
to
+58
| botName := c.config.Agents.Defaults.BotName | ||
| if botName == "" { | ||
| botName = "PicoClaw" | ||
| } |
Contributor
There was a problem hiding this comment.
I would look at moving the bot name to the telegram config vs using the default agent
Comment on lines
+35
to
+42
| func NewDingTalkChannel(cfg config.DingTalkConfig, messageBus *bus.MessageBus, botName string) (*DingTalkChannel, error) { | ||
| if cfg.ClientID == "" || cfg.ClientSecret == "" { | ||
| return nil, fmt.Errorf("dingtalk client_id and client_secret are required") | ||
| } | ||
|
|
||
| if botName == "" { | ||
| botName = "PicoClaw" | ||
| } |
Contributor
There was a problem hiding this comment.
Like wise move the bot name to DingTalk config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/startgreeting in Telegram and the DingTalk reply title were hardcoded as "PicoClaw". Users who customize their bot's identity viasoul.mdstill seeHello! I am PicoClawon the first message, which breaks their custom identity.This PR adds a
bot_nameconfig field so all channels use the configured name.Changes
pkg/config/config.goBotNamefield toAgentDefaults(default:"PicoClaw")pkg/channels/telegram_commands.go/startgreeting uses configuredbot_namepkg/channels/dingtalk.gobot_namepkg/channels/manager.gobot_nameto DingTalk channel constructorConfig Example
{"agents": {"defaults": {"bot_name": "MyBot"}}}Or via environment variable:
Backward Compatible
"PicoClaw"— no change for existing usersCloses #288