Replace \s+ with [^\S\n]+ to preserve newlines#299
Open
mattn wants to merge 1 commit intosipeed:mainfrom
Open
Conversation
Collaborator
|
@Zepan This PR by @mattn replaces Recommendation: Merge. Correct regex behavior that preserves formatting. Well-tested by a contributor who clearly understands Go regex edge cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractTextinpkg/tools/web.goreplaces all whitespace (including newlines) with a single space using\s+, then tries to split by\nto filter empty lines. Since all newlines are already gone, the output is always a single line.