fix: env overrides when config.json is missing and add regression test#271
Open
tbeaudouin05 wants to merge 2 commits intosipeed:mainfrom
Open
fix: env overrides when config.json is missing and add regression test#271tbeaudouin05 wants to merge 2 commits intosipeed:mainfrom
tbeaudouin05 wants to merge 2 commits intosipeed:mainfrom
Conversation
|
Good catch on the LoadConfig logic! It seems like we're both looking at the parsing order of environment variables. I've actually just updated PR #239 which handles this by unsetting conflicting env vars at the entrypoint level (ensuring the JSON remains the source of truth) while also adding full Coolify/Docker support. It might be worth checking how we can unify these so they don't fight each other! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.