Feature: last submission status #606
Open
+114
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasloMaslane
requested changes
Jan 3, 2026
Member
MasloMaslane
left a comment
MasloMaslane
left a comment
There was a problem hiding this comment.
Also I don't really like that the badge is next to the title. Maybe it could be immediately to the left of the score?
Comment on lines
+173
to
+188
| # Bulk fetch user's submissions for the problem instances and build a map | ||
| # of latest submission per problem instance. Submissions are ordered by | ||
| # date descending, so the first occurrence for a given problem_instance | ||
| # is the latest one. | ||
| submissions_qs = ( | ||
| Submission.objects.filter( | ||
| user__id=request.user.id, | ||
| problem_instance_id__in=pi_ids, | ||
| kind="NORMAL" # ignore ignored submissions | ||
| ) | ||
| .order_by("-date") | ||
| ) | ||
| for s in submissions_qs: | ||
| pid = s.problem_instance_id | ||
| if pid not in last_submission_map: | ||
| last_submission_map[pid] = s |
Member
There was a problem hiding this comment.
it shouldn't always fetch last submission, for example in some contests max submission counts as the score (OI, OIJ).
In this PR #405 there are functions implemented that return scored submission effectively. Maybe you can copy them here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a badge to each problem row in the problems tab. The badge display the status of the users last submission for that problem, like "Initial tests: failed" or "Pending". It is displayed only for normal (not ignored submissions).
