Parallellize rankings' recalculation #596
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of rankingsd instances can be controlled by the RANKINGSD_CONCURRENCY setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #585. This PR will close that issue when I add optimizations in the actual recalculations.
Other performance optimisations mentioned in that issue will arrive in another PR.
The number of rankingsd instances can be controlled by the RANKINGSD_CONCURRENCY setting.
A value of 0 also works. Logging is done to separate files.
It seems that the only change in rankingsd code required for this to work was adding
recalc_in_progress=Noneto the query's filter inchoose_for_recalculation.I tested this with 3 rankingsd instances and ~2500 ranking recalculations on a real/proper sio2 instance, and it indeed resulted in a 3x speedup.
TODO: unset recalc_in_progress on error.