Created new type ScenTreeNodes for StrategicScenario
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The new type allows for the functionality `last` * No other impact of the new type
trulsf
approved these changes
Jan 5, 2026
Member
trulsf
left a comment
trulsf
left a comment
There was a problem hiding this comment.
Looks good to me. I would not see this as a breaking change. The behavior of the exported functions are not changed. I see the exact type returned as an internal type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version,
strategic_periods(scen::StrategicScenario)creates a typeStratTreeNodes. This is generally not wrong, but limits the reusability of functions as certain functionality is not defined forStratTreeNodes, among otherslast.This is adjusted in this PR.
Important
Do we see it as breaking? The type is changed, but the iterator still behaves exactly the same. This implies it may be breaking if people use the type for dispatch.