Cache total_duration for OperationalScenarios and SimpleTimes structs #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulStraus
reviewed
Nov 17, 2025
Collaborator
There was a problem hiding this comment.
Not too many comments from my end. We had it included for RepresentativePeriods beforehand (although with a different meaning). The usage of an internal constructor is also beneficial.
One thing we should however be clearer on is the differentiation on what the function does for a TwoLevel and the different "operational" time structures. This boils essentially down to the differentiation between the duration of a strategic period and the duration of an operational period. I could come one within November with a suggestion for an improved documentation for it.
Edit: You forgot the JuliaFormatter ;) Should CalendarTimes also get the update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some algorithmic work where we use iterators inside algorithmic loops the calculation of
total_durationdominates time usage and it may be worthwhile to cache these as part of the structure.