Improve icon sizing #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the frame's char height, set the icon's maximum height relative to the surrounding text. Additionally, center icons on the line (to avoid increasing the line height.
Owner
|
Cool, thanks! I might tweak the exact image descriptor at some point, because a visible baseline (like in my mode line) now intersects the notification icon, but the scrolling behavior is clearly superior to what it was before. |
Contributor
Author
|
Thanks! FYI, you can tell Emacs to draw an underline at the descent-line instead of at the base-line by specifying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the frame's char height, set the icon's maximum height relative to the surrounding text. Additionally, center icons on the line (to avoid increasing the line height.