Skip to content

Fix about page tests and add no-admin merge rule #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singhsanjay12 merged 1 commit into from
Mar 24, 2026
Merged

Fix about page tests and add no-admin merge rule #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- **Never push directly to `main`.** All changes must go through a pull request, no exceptions — including config changes, quick fixes, and single-line edits.
- Always create a new branch before making changes. Branch names must follow the `ssingh1/<description>` convention (e.g. `ssingh1/add-analytics`).
- Open a PR after pushing the branch. Only merge after review.
- **Never use `--admin` flag when merging PRs.** It bypasses branch protection rules and required status checks (tests, CI). If a PR is not mergeable, fix the underlying issue instead.

## GitHub Account

Expand Down
8 changes: 4 additions & 4 deletions tests/about_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ def test_experience_timeline
end

def test_linkedin_tenure
assert_match(/2015.*Present|Present.*2015/m, @html,
"Experience timeline must show 2015 – Present for LinkedIn")
assert_match(/Staff Software Engineer/, @html,
"Experience timeline must show Staff Software Engineer role at LinkedIn")
end

def test_education_section
assert_match(/Motilal Nehru/, @html,
"Education section must list MNNIT Allahabad")
assert_match(/NIT Allahabad/, @html,
"Education section must list NIT Allahabad")
end

def test_focus_cards
Expand Down
Loading