Allow user to disable private channels#7
Open
andrewrjones wants to merge 2 commits intosinger-io:masterfrom
Open
Allow user to disable private channels#7andrewrjones wants to merge 2 commits intosinger-io:masterfrom
andrewrjones wants to merge 2 commits intosinger-io:masterfrom
Conversation
By default, we will still get private channels. This requires the extra `groups:` scopes. Previously, even if we didn't want to sync private groups, the calls to the Slack API would fail as the calls we made defined the types as `"public_channel,private_channel"`. There is now an optional config, `private_channels`, that allows the user to disable private channels in the config file. Also added documentation for the config file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Previously, even if we didn't want to sync private groups, the calls to
the Slack API would fail as the calls we made defined the types as
"public_channel,private_channel".There is now an optional config,
private_channels, that allows theuser to disable private channels in the config file.
By default, we will still get private channels. This requires the extra
groups:scopes.Also added documentation for the config file.
Manual QA steps
Run the tap without any additional config and it should perform as it did previously
Run the tap with
"private_channels":trueand it should perform as it did previouslyRun the tap with
"private_channels":falseand it will now only sync public channelsRun the tap without any additional config and with a Slack account that does not have the
group:permissions and it will fail with the following:"private_channels":falseand it will now only sync public channels and not fail with an errorRisks
Rollback steps