Conversation
* change slack client to sdk * commit for changelof * commit for changelog * revert fstring comments
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Slack client from the deprecated slackclient library to the modern slack-sdk library, including updating dependencies and adding parent stream metadata for better data lineage.
- Updated Slack client dependency from
slackclient==2.6.0toslack-sdk==3.36.0 - Added parent stream metadata to conversation-related streams for improved data lineage
- Upgraded
singer-pythonversion and removed deprecated Python version requirement
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tap_slack/init.py | Updated import from deprecated slack to slack_sdk WebClient |
| tap_slack/client.py | Updated SlackApiError import and made wait method static |
| tap_slack/streams.py | Added parent stream metadata to conversation-related streams |
| tap_slack/catalog.py | Enhanced catalog generation to support parent stream metadata |
| setup.py | Updated dependencies and version, removed deprecated Python requirement |
| CHANGELOG.md | Added changelog entry for version 1.2.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if parent_tap_stream_id: | ||
| mdata = singer.metadata.write(mdata, (), 'parent-tap-stream-id', parent_tap_stream_id) | ||
|
|
||
| mdata = singer.metadata.to_list(mdata) |
There was a problem hiding this comment.
Extra trailing whitespace should be removed.
| mdata = singer.metadata.to_list(mdata) | |
| mdata = singer.metadata.to_list(mdata) |
There was a problem hiding this comment.
Please remove this trailing whitespace.
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Changes look good now. I am approving this PR since functionally it looks fine but please take care of comment before merging it.
Description of change
This PR is for upgrade slack client to slack sdk
SAC-28386
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code