Fix thread_ts values in messages and threads streams#12
Open
koszti wants to merge 2 commits intosinger-io:masterfrom
Open
Fix thread_ts values in messages and threads streams#12koszti wants to merge 2 commits intosinger-io:masterfrom
koszti wants to merge 2 commits intosinger-io:masterfrom
Conversation
|
Hey all! Can someone merge this commit? Without it it's impossible to associate a thread with a parent message! Thank you :) |
egwoo
approved these changes
Sep 20, 2023
|
Bumping this PR as we're running into the same issue |
|
Bumping this once more as we're also running into it. |
|
Bumping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Cannot join
messagesandthreadstables becausethread_tscolumn not populated correctly.Manual QA steps
messages.thread_tsshould be populated by conversations.history API endpoint andthreads.thread_tsshould be populated by conversations.replies endpointRisks
Rollback steps