Skip to content

Return get_channel result as simple value#11

Open
koszti wants to merge 2 commits intosinger-io:masterfrom
koszti:patch-2
Open

Return get_channel result as simple value#11
koszti wants to merge 2 commits intosinger-io:masterfrom
koszti:patch-2

Conversation

@koszti
Copy link
Copy Markdown

@koszti koszti commented Sep 30, 2020

Description of change

The tap is not working if channels parameter defined in config.json.
The get_channel should return a plain value and not an iterable by yield.

Manual QA steps

Risks

Rollback steps

  • revert this branch

@robswn
Copy link
Copy Markdown

robswn commented Oct 18, 2022

Can confirm I was also experiencing this issue and the proposed fix worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants